Annotate the no-return from die()

In all crates we are using a die() function to print to stderr and quit
with a exit status > 0. Apparently in Rust you can annotate the return
type with a bang just like the noreturn from the C family.

The added bonus is that some useless statements to make the compiler
happy without it can be removed altogether as now the compiler is able
to understand that it won't return so the returned type is not needed.

Signed-off-by: Miquel Sabaté Solà <mssola@mssola.com>

1 files changed, 2 insertions, 6 deletions

diff --git a/crates/readrom/src/main.rs b/crates/readrom/src/main.rs
index ef7fa9b..8d70e16 100644
--- a/crates/readrom/src/main.rs
+++ b/crates/readrom/src/main.rs
@@ -175,7 +175,7 @@ fn print_vectors(addrs: &[u8]) {
 }
 
 // Print the given `message` and exit(1).
-fn die(message: String) {
+fn die(message: String) -> ! {
     println!("error: {message}");
     std::process::exit(1);
 }
@@ -527,7 +527,6 @@ fn main() {
     // Open the ROM file and read it.
     let Ok(mut input) = File::open(&args.file) else {
         die(format!("failed to open the given file '{}'", args.file));
-        return;
     };
     let mut bytes = Vec::new();
     if let Err(e) = input.read_to_end(&mut bytes) {
@@ -553,10 +552,7 @@ fn main() {
 
     let header = match Header::try_from(buf) {
         Ok(h) => h,
-        Err(e) => {
-            die(e.to_string());
-            return;
-        }
+        Err(e) => die(e.to_string()),
     };
     print_header(&header);