aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiquel Sabaté Solà <msabate@suse.com>2020-04-05 12:26:13 +0200
committerMiquel Sabaté Solà <msabate@suse.com>2020-04-05 12:26:13 +0200
commiteb0d6621c991557964823c8af326a5dfdc56dd6f (patch)
treea9b4273340dc1ab35a17995065e586a501193cf0
parentc3551def989ca5418468b64939f991ed042eabf1 (diff)
downloadsoria-eb0d6621c991557964823c8af326a5dfdc56dd6f.tar.gz
soria-eb0d6621c991557964823c8af326a5dfdc56dd6f.zip
Enable byte compiling and lexical binding
Moreover, require the minimum GNU Emacs version in the package metadata, not dinamically. Also add 25.1 in the .travis.yml matrix, so the minimum support GNU Emacs is also tested in CI. As recommended by @riscy in https://github.com/melpa/melpa/pull/6808. Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
-rw-r--r--.travis.yml3
-rw-r--r--soria-theme.el10
2 files changed, 5 insertions, 8 deletions
diff --git a/.travis.yml b/.travis.yml
index 7007671..1ffcc6c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,6 +2,9 @@ language: nix
sudo: true
env:
+ # The minimum required plus the latest from each major release plus the next
+ # release.
+ - EMACS_CI=emacs-25-1
- EMACS_CI=emacs-25-3
- EMACS_CI=emacs-26-3
- EMACS_CI=emacs-snapshot
diff --git a/soria-theme.el b/soria-theme.el
index a4a1b1e..14788ae 100644
--- a/soria-theme.el
+++ b/soria-theme.el
@@ -1,4 +1,4 @@
-;;; soria-theme.el --- A xoria256 theme with some colors from openSUSE
+;;; soria-theme.el --- A xoria256 theme with some colors from openSUSE -*- lexical-binding: t; -*-
;; Copyright (C) 2016-2020 Miquel Sabaté Solà <mikisabate@gmail.com>
;;
@@ -17,6 +17,7 @@
;; Author: Miquel Sabaté Solà <mikisabate@gmail.com>
;; Version: 0.2
+;; Package-Requires: ((emacs "25.1"))
;; Keywords: faces
;; URL: https://github.com/mssola/soria
@@ -42,9 +43,6 @@
;; Defining the theme and its configuration group.
-(unless (>= emacs-major-version 24)
- (error "The soria theme requires Emacs 24 or later!"))
-
(deftheme soria "A xoria256 theme with some colors from openSUSE")
(defgroup soria nil
@@ -1388,8 +1386,4 @@ identifiers"
;; Make package-lint happy. This file is not meant to be used as a library.
(provide 'soria-theme)
-;; Local Variables:
-;; no-byte-compile: t
-;; End:
-
;;; soria-theme.el ends here