diff options
| author | Miquel Sabaté Solà <mikisabate@gmail.com> | 2024-05-10 07:52:36 +0200 |
|---|---|---|
| committer | Miquel Sabaté Solà <mikisabate@gmail.com> | 2024-05-10 07:52:36 +0200 |
| commit | 65286e60284f0fa05e8d1916426f180ab6a60b60 (patch) | |
| tree | e5de491a95e542dc41c2a2bc0a6a6b02464bfd68 | |
| parent | a1fcf17883209ee4f3c7defaaa00676cb902c718 (diff) | |
| download | soria-65286e60284f0fa05e8d1916426f180ab6a60b60.tar.gz soria-65286e60284f0fa05e8d1916426f180ab6a60b60.zip | |
ci: git-validation can go suck an egg
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
| -rw-r--r-- | .github/workflows/ci.yml | 5 | ||||
| -rw-r--r-- | CONTRIBUTING.org | 19 | ||||
| -rw-r--r-- | Makefile | 10 |
3 files changed, 1 insertions, 33 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7488ce0..f47d2d7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,12 +40,7 @@ jobs: with: version: ${{ matrix.emacs_version }} - - uses: actions/setup-go@v5 - - uses: actions/checkout@v4 - - name: Install git-validation - run: go install github.com/vbatts/git-validation@latest - - name: make ci run: make ci diff --git a/CONTRIBUTING.org b/CONTRIBUTING.org index ab276e6..34d5f96 100644 --- a/CONTRIBUTING.org +++ b/CONTRIBUTING.org @@ -31,25 +31,6 @@ style. You can run these checkers by performing: $ make lint #+END_SRC -*** Git validation - -In order to ensure that the git log is as maintainable as possible, the -[[https://github.com/vbatts/git-validation][git-validation]] tool is used. You can install this tool by running: - -#+BEGIN_SRC bash -$ go get -u github.com/vbatts/git-validation -#+END_SRC - -If you already have this tool installed, then simply perform: - -#+BEGIN_SRC bash -$ make git-validation -#+END_SRC - -Note that if you don't have this tool installed the task will do nothing (it -will just print a help message). This is done so when running the default make -task this doesn't interrupt it. - *** Load test In order to test that this theme can be actually loaded, run: @@ -36,7 +36,7 @@ $(OBJECTS): %.elc: %.el ci: version all .PHONY: test -test: lint git-validation checkdoc load-test +test: lint checkdoc load-test # Maybe it would've been nicer to use Cask or something like that, but it # doesn't have too many dependencies so it should be fine for now. @@ -70,14 +70,6 @@ fix-stdlib-changes: lint: vendor fix-stdlib-changes @$(BATCH) -l elisp-lint.el -f elisp-lint-files-batch $(ELS) -.PHONY: git-validation -git-validation: -ifeq (, $(shell which git-validation 2> /dev/null)) - @echo "You don't have 'git-validation' installed, consider installing it (see the CONTRIBUTING.org file)." -else - @git-validation -q -range 7d38ca68163c..HEAD -travis-pr-only=false -endif - .PHONY: load-test load-test: @$(BATCH) -nw --load soria-theme.el \ |
