csv: don't export underscores on "authors"

It does not make sense on this context.

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>

2 files changed, 5 insertions, 7 deletions

diff --git a/lib/csv_exporter.rb b/lib/csv_exporter.rb
index 0463ba6..3cab092 100644
--- a/lib/csv_exporter.rb
+++ b/lib/csv_exporter.rb
@@ -16,14 +16,9 @@ class CsvExporter < BaseExporter
 
   # Generate a new CSV line from the given `thing`.
   def thing_to_csv(thing:)
-    CSV.generate_line([thing.target, thing.authors, thing.editors, thing.year,
-                       clean_title(title: thing.title), thing.note, thing.insideof,
+    CSV.generate_line([thing.target, thing.authors.delete('_'), thing.editors, thing.year,
+                       thing.title.delete('_'), thing.note, thing.insideof,
                        thing.url, thing.publisher, thing.kind, thing.access, thing.bought_at],
                       quote_empty: false)
   end
-
-  # Clean the given title from underscores and other such characters.
-  def clean_title(title:)
-    title.delete('_')
-  end
 end
diff --git a/test/controllers/exports_controller_test.rb b/test/controllers/exports_controller_test.rb
index eefff6f..fe94362 100644
--- a/test/controllers/exports_controller_test.rb
+++ b/test/controllers/exports_controller_test.rb
@@ -8,6 +8,9 @@ class ExportsControllerTest < ActionDispatch::IntegrationTest
     get search_exports_url(0, format: 'csv')
 
     body = @response.body.split("\n")
+
+    assert_nil body.last.index('_')
+
     targets = body.map { |b| b.split(',').first }
 
     assert_equal targets, [things(:thing2).target, things(:thing1).target]