From e9f149a590b019a0c2f55d1fb407461df1119ff2 Mon Sep 17 00:00:00 2001
From: Miquel Sabaté Solà <mikisabate@gmail.com>
Date: Tue, 29 Oct 2024 14:19:42 +0100
Subject: Fix bug on multiple arguments for macros
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
---
 lib/xixanta/src/assembler.rs | 74 +++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 69 insertions(+), 5 deletions(-)

(limited to 'lib')

diff --git a/lib/xixanta/src/assembler.rs b/lib/xixanta/src/assembler.rs
index 7d09ec2..e614b42 100644
--- a/lib/xixanta/src/assembler.rs
+++ b/lib/xixanta/src/assembler.rs
@@ -369,10 +369,10 @@ impl Assembler {
         if nargs > 0 {
             let mut margs = mcr.args.iter();
 
-            for (idx, arg) in args.unwrap().iter().enumerate() {
+            for arg in args.unwrap().iter() {
                 let bundle = self.evaluate_node(arg)?;
                 self.context
-                    .set_variable(margs.nth(idx).unwrap(), &bundle, false)?;
+                    .set_variable(margs.next().unwrap(), &bundle, false)?;
             }
         }
 
@@ -737,15 +737,15 @@ impl Assembler {
     }
 
     fn evaluate_control_expression(&mut self, node: &PNode) -> Result<Bundle, EvalError> {
-        let function = node.value.value.as_str();
+        let function = node.value.value.to_lowercase();
 
-        match function {
+        match function.as_str() {
             ".hibyte" => self.evaluate_byte(node, true),
             ".lobyte" => self.evaluate_byte(node, false),
             _ => Err(EvalError {
                 line: node.value.line,
                 message: format!(
-                    "cannot handle control statement '{}' in this context",
+                    "cannot handle control statement '{}' as an expression in this context",
                     function
                 ),
             }),
@@ -1856,6 +1856,70 @@ MACRO(1)
         );
     }
 
+    #[test]
+    fn macro_multiple_arguments() {
+        let mut asm = Assembler::new(EMPTY.to_vec());
+        let res = asm
+            .assemble(
+                r#"
+.macro WRITE_PPU_DATA address, value
+    bit $2002                   ; PPUSTATUS
+    lda #.HIBYTE(address)
+    sta $2006                   ; PPUADDR
+    lda #.LOBYTE(address)
+    sta $2006                   ; PPUADDR
+    lda #value
+    sta $2007                   ; PPUDATA
+.endmacro
+
+WRITE_PPU_DATA $20B9, $04
+"#
+                .as_bytes(),
+            )
+            .unwrap();
+
+        assert_eq!(res.len(), 7);
+
+        // bit $2002
+        assert_eq!(res[0].size, 3);
+        assert_eq!(res[0].bytes[0], 0x2C);
+        assert_eq!(res[0].bytes[1], 0x02);
+        assert_eq!(res[0].bytes[2], 0x20);
+
+        // lda #.HIBYTE(address)
+        assert_eq!(res[1].size, 2);
+        assert_eq!(res[1].bytes[0], 0xA9);
+        assert_eq!(res[1].bytes[1], 0x20);
+
+        // sta $2006
+        assert_eq!(res[2].size, 3);
+        assert_eq!(res[2].bytes[0], 0x8D);
+        assert_eq!(res[2].bytes[1], 0x06);
+        assert_eq!(res[2].bytes[2], 0x20);
+
+        // lda #.LOBYTE(address)
+        assert_eq!(res[3].size, 2);
+        assert_eq!(res[3].bytes[0], 0xA9);
+        assert_eq!(res[3].bytes[1], 0xB9);
+
+        // sta $2006
+        assert_eq!(res[4].size, 3);
+        assert_eq!(res[4].bytes[0], 0x8D);
+        assert_eq!(res[4].bytes[1], 0x06);
+        assert_eq!(res[4].bytes[2], 0x20);
+
+        // lda #value
+        assert_eq!(res[5].size, 2);
+        assert_eq!(res[5].bytes[0], 0xA9);
+        assert_eq!(res[5].bytes[1], 0x04);
+
+        // sta $2007
+        assert_eq!(res[6].size, 3);
+        assert_eq!(res[6].bytes[0], 0x8D);
+        assert_eq!(res[6].bytes[1], 0x07);
+        assert_eq!(res[6].bytes[2], 0x20);
+    }
+
     // Segments
     // TODO: segments as is, fill data, jmp's
 }
-- 
cgit v1.2.3