From 85a68dbdcd0200a711bacda9c7170129350813c8 Mon Sep 17 00:00:00 2001 From: Miquel Sabaté Solà Date: Fri, 5 Jun 2026 23:32:39 +0200 Subject: Refer to the original file for unused objects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When warning users on unused objects (e.g. variables, proc's), we have to pick up the source of origin for this warning. In places where the original PNode is not available, then we go with the last source we have at hand, as that's the usual way to go (i.e. the error occurred at the current source/context). That being said, for unused objects that's not desirable, because we might otherwise claim the error to happen on the file we first targetted, but it's way more useful to understand where the object was defined. Hence, when defining a variable, address or proc, let's actually store the PNode associated with it as well. This way the checker can hopefully get the source from this PNode and be more clear to the user. Signed-off-by: Miquel Sabaté Solà --- lib/xixanta/src/object.rs | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) (limited to 'lib/xixanta/src/object.rs') diff --git a/lib/xixanta/src/object.rs b/lib/xixanta/src/object.rs index 1887b77..36b15dc 100644 --- a/lib/xixanta/src/object.rs +++ b/lib/xixanta/src/object.rs @@ -142,8 +142,10 @@ pub struct Object { pub bundle: Bundle, /// Node which marks the source of the computed `bundle` attribute. This is - /// only provided in cases like macro calls where at the crunching stage we - /// might need to fetch previous context for the current `bundle` value. + /// provided in cases like macro calls where at the crunching stage we might + /// need to fetch previous context for the current `bundle` value. It is + /// also provided in variable definitions, as an indirect way to fetch the + /// original source containing the definition. pub node: Option, /// The mapping index where the object was found. Note that this index @@ -169,22 +171,6 @@ pub struct Object { pub accessed: usize, } -impl Object { - /// Create a default bundle with the given metadata parameters. - pub fn new(mapping: usize, segment: usize, object_type: ObjectType) -> Self { - Self { - bundle: Bundle::default(), - node: None, - mapping, - segment, - object_type, - asan_ignore: false, - asan_reserve: 1, - accessed: 0, - } - } -} - /// Context holds information about the different scopes being defined, the /// current scope, and has a map of all the variables defined for each scope. #[derive(Debug)] -- cgit v1.2.3