tools.nes/lib/xixanta/src/errors.rs, branch mainTools for NES/Famicom development.
https://git.mssola.com/nes/tools.nes/atom?h=main2025-01-09T15:30:01ZMerge all error types into a single one2025-01-09T15:30:01ZMiquel Sabaté Solàmikisabate@gmail.com2025-01-09T15:26:20Zurn:sha1:92092ccc245269e0c3a864d06f7e382a5bb9d8b0
They started with good intentions, but in the end they were all pretty
much alike. Hence, it makes sense to simplify everything and provide a
single struct.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Remove ContextErrorReason as it was unused2025-01-09T15:06:34ZMiquel Sabaté Solàmikisabate@gmail.com2025-01-09T15:06:34Zurn:sha1:0f6e6d0b2f6887e025a08a862b55288f871e62ca
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Implement the .include statement2025-01-09T15:01:39ZMiquel Sabaté Solàmikisabate@gmail.com2025-01-08T11:34:47Zurn:sha1:8b1c270910fce13077864bf39d6e88971a6eb062
This needed some heavy lifting when it comes to how files were located.
This means that statements like .include/.incbin now take into
consideration a new list made out of SourceInfo, which holds enough
information to translate from which file a node comes from. This has
also been added into errors, so they are more informative on what went
wrong.
In order to tests this, besides all the regular unit tests, a new e2e
test has been added.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Fix usage of labels inside of macros2024-12-24T14:41:22ZMiquel Sabaté Solàmikisabate@gmail.com2024-12-24T14:41:22Zurn:sha1:e611f38c9d056da01b2cc3a532f9013ad1ee567a
Instead of calling `evaluate_node` for each node on a macro, just call
`Assembler::bundle` for the list of nodes so the context is preserved
and labels and other statements can be catched as usual.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Prevent missplaced start for procs and scopes2024-12-23T15:30:38ZMiquel Sabaté Solàmikisabate@gmail.com2024-12-23T15:30:38Zurn:sha1:bbf91bf3abaff31231763352af405a2c22061c90
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Prevent early .end statements2024-12-23T15:05:17ZMiquel Sabaté Solàmikisabate@gmail.com2024-12-23T15:05:17Zurn:sha1:2f40bc30185027a125f782e52b65bc65f1c37b9b
Prevent a missmatch on .end{macro,proc,scope}. This was more or less
already covered when there was a bad context_pop call, but it was prone
to errors.
Check this in eval_context as it should've always been done.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Improve the format of error messages2024-12-20T12:06:40ZMiquel Sabaté Solàmikisabate@gmail.com2024-12-20T12:04:39Zurn:sha1:19e4da9fd654886f1a49dfb3509daa6526401774
It was weird to show warnings which also showed "Error: " as a message,
and likewise it was weird for errors to display their kind, since users
simply do not care about this kind of information.
Hence, streamline the format to something closer to what it's done by
modern assemblers/compilers.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Prevent addresses which are out of bounds2024-12-18T09:25:12ZMiquel Sabaté Solàmikisabate@gmail.com2024-12-18T09:25:12Zurn:sha1:03dae41b2ec20905af780bbcf5c033f683f19efb
In some bad scenarios addresses might be pointing out of bounds (e.g. a
reference further than 0xFFFF). This has to be avoided and through fuzzy
testing we even got Rust panics for out of bounds u16 arithmetic. Hence,
just go through usize for the actual computation and check with
u16::MAX.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Remove From<std::io::Error> from errors2024-12-18T08:23:16ZMiquel Sabaté Solàmikisabate@gmail.com2024-12-18T08:23:16Zurn:sha1:49bd7e8e49655da83d64969a54c6281bd6c6d2fe
Having a From<std::io::Error> came from a hacky beginning in which
std::io::Error was being abused. Now the error handling is saner, so
there's no more need for that.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
Re-work the handling of segments in the assembler2024-12-12T06:55:55ZMiquel Sabaté Solàmikisabate@gmail.com2024-11-05T12:39:16Zurn:sha1:f0624b8929e6ead3f2d8b1939dc7f094c539bee1
There were a lot of assumptions on the assembler that stemmed from a
fundamental missunderstanding from my side on how segments are laid out
on the final file. This commit is the first step to address this.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>