tools.nes/crates/readrom/src, branch main

Annotate the no-return from die()

2026-08-24T12:16:42Z

In all crates we are using a die() function to print to stderr and quit with a exit status > 0. Apparently in Rust you can annotate the return type with a bang just like the noreturn from the C family. The added bonus is that some useless statements to make the compiler happy without it can be removed altogether as now the compiler is able to understand that it won't return so the returned type is not needed. Signed-off-by: Miquel Sabaté Solà

readrom: read the ROM file right on start

2026-07-23T10:45:59Z

This avoids exhausting the input in other scenarios (thus fixing commit f5549b97bf85 ("readrom: only read the ROM file once")), and it makes everything more cohesive. Fixes: f5549b97bf85 ("readrom: only read the ROM file once") Signed-off-by: Miquel Sabaté Solà

readrom: only read the ROM file once

2026-07-16T14:52:52Z

Since the implementation grew from disassembling a single subroutine, reading the ROM file from inside print_range() made sense. But since we have disassembling of full segments and files now, this reading would be triggered multiple times. Commit d7b1a895de9e ("readrom: add an option to disassemble the full file") avoided the exhaustion of the input by using seek(), but that's just a hack and it's hiding the fact that we are constantly reading the same thing over and over. Constantly reading ROM files isn't that much of a performance issue given how small they are, but it's embarrasing anyways. Fix this by reading the full file once and passing the slice of bytes to the same functions that used to require the file to be passed. Signed-off-by: Miquel Sabaté Solà

readrom: add an option to disassemble the full file

2026-07-16T14:43:58Z

Signed-off-by: Miquel Sabaté Solà

readrom: allow to disassemble a mapping

2026-07-16T14:43:27Z

Signed-off-by: Miquel Sabaté Solà

readrom: implement the -d/--disassemble option

2026-07-15T20:11:50Z

This option can also be coupled with -n/--nasm-directory, and you can then get a human-readable disassembling of any proc or label you might be thinking on. Signed-off-by: Miquel Sabaté Solà

readrom: print the usual PRG-RAM size if available

2026-07-13T15:37:43Z

If 'has_persistent_memory' has been set on the ROM header, then we must print it even if bytes 8/10 was never set by the header. In fact, the vast majority of ROM files don't have these bytes set but they report a true value for 'has_persistent_memory'. Hence, assume the usual PRG-RAM size in these cases, which is (I hope) the correct one in all cases. Signed-off-by: Miquel Sabaté Solà

Minor style fixes from an upgraded clippy

2026-07-09T20:14:40Z

Signed-off-by: Miquel Sabaté Solà

readrom: Add detection of RAM, Timing and mirroring

2025-09-12T19:55:20Z

Signed-off-by: Miquel Sabaté Solà

Add -h and -v options on the help message

2025-09-02T05:29:24Z

On all binaries there were these two options missing from the help message. Signed-off-by: Miquel Sabaté Solà