From 64e2bca8326bd46a2ad80b6a7a430dea0f81ff6b Mon Sep 17 00:00:00 2001
From: Miquel Sabaté Solà <msabate@suse.com>
Date: Thu, 14 Mar 2024 11:34:28 +0100
Subject: Added rubocop-minitest
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
---
 test/models/thing_test.rb | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

(limited to 'test/models/thing_test.rb')

diff --git a/test/models/thing_test.rb b/test/models/thing_test.rb
index 0b3961e..766a5e2 100644
--- a/test/models/thing_test.rb
+++ b/test/models/thing_test.rb
@@ -3,36 +3,28 @@
 require 'test_helper'
 
 class ThingTest < ActiveSupport::TestCase
-  test 'validates presence' do
-    assert_raise(ActiveRecord::RecordInvalid) { Thing.new.save! }
-
-    # Missing 'title'
+  test 'presence: title' do
     assert_raise(ActiveRecord::RecordInvalid) do
       Thing.new(target: 'target', authors: 'Author',
                 user_id: users(:user).id, rate: 5,
                 status: Thing.statuses[:read], kind: Thing.kinds[:novel]).save!
     end
+  end
 
-    # Missing 'target'
+  test 'presence: target' do
     assert_raise(ActiveRecord::RecordInvalid) do
       Thing.new(title: 'title', authors: 'Author',
                 user_id: users(:user).id, rate: 5,
                 status: Thing.statuses[:read], kind: Thing.kinds[:novel]).save!
     end
+  end
 
-    # Missing 'authors'
+  test 'presence: authors' do
     assert_raise(ActiveRecord::RecordInvalid) do
       Thing.new(title: 'title', target: 'target',
                 user_id: users(:user).id, rate: 5,
                 status: Thing.statuses[:read], kind: Thing.kinds[:novel]).save!
     end
-
-    # Valid!
-    assert_difference('Thing.count') do
-      Thing.new(title: 'title', target: 'target', authors: 'Author',
-                user_id: users(:user).id, rate: 5,
-                status: Thing.statuses[:read], kind: Thing.kinds[:novel]).save!
-    end
   end
 
   test "'rate' has to be between 0 and 10" do
@@ -85,11 +77,13 @@ class ThingTest < ActiveSupport::TestCase
 
   test 'has many comments' do
     thing = things(:thing1)
-    assert thing.comments.size == 1
+
+    assert_equal 1, thing.comments.size
   end
 
   test 'has many tags through tag_references' do
     thing = things(:thing1)
-    assert thing.tags.size == 2
+
+    assert_equal 2, thing.tags.size
   end
 end
-- 
cgit v1.2.3